feat: toolbar UI update (DHIS2-15167) #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
force-pushed
the
DHIS2-15167-toolbar-update
branch
from
30764fd
to
a9d6182
Compare
|
🚀 Deployed on https://pr-368--dhis2-line-listing.netlify.app |
2 tasks
2 tasks
HendrikThePendric
force-pushed
the
DHIS2-15167-toolbar-update
branch
from
eaa467d
to
2c235d7
Compare
HendrikThePendric
force-pushed
the
DHIS2-15167-toolbar-update
branch
from
d9d2366
to
a568a21
Compare
19 failed and 4 flaky tests on run #1590 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| file menu > reflects "saved, valid: data" state |
Output
Screenshots
Video
|
|
| file menu > reflects "dirty" state |
Output
Screenshots
Video
|
|
interpretations.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| interpretations > the interpretations panel can be toggled when clicking the button in the toolbar |
Output
Screenshots
Video
|
|
programDimensions.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| program dimensions > event > program can be selected and cleared |
Output
Screenshots
Video
|
|
table.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| table > dimensions display correct values in the visualization (>=2.39) |
Output
Screenshots
Video
|
|
timeDimensions.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| time dimensions > scheduledDate shows the correct title in layout and table header |
Output
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 15 specs in Cypress Cloud.
options.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| ou hierarchy > sets organisation unit hierarchy |
Output
Screenshots
|
|
fileMenu.cy.js • 1 flaky test • e2e-chrome-parallel-2.39
| Test | Artifacts | |
|---|---|---|
| file menu > reflects "saved, valid: save" state |
Output
Screenshots
Video
|
|
fileMenu.cy.js • 1 flaky test • e2e-chrome-parallel-2.38
| Test | Artifacts | |
|---|---|---|
| file menu > reflects "saved, valid: save" state |
Output
Screenshots
Video
|
|
conditions/dateConditions.cy.js • 1 flaky test • e2e-chrome-parallel-2.38
| Test | Artifacts | |
|---|---|---|
| date conditions (Date) > before |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
edoardo
approved these changes
Jun 23, 2023
HendrikThePendric
force-pushed
the
DHIS2-15167-toolbar-update
branch
from
d001129
to
af477f8
Compare
HendrikThePendric
force-pushed
the
DHIS2-15167-toolbar-update
branch
from
1cec12e
to
6b8f5e5
Compare
|
As agreed with @janhenrikoverland I returned this PR to draft and added the "on hold" label. We won't be doing any releases until august. |
janhenrikoverland
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Aug 9, 2023
# [100.9.0](v100.8.2...v100.9.0) (2023-08-09) ### Features * toolbar UI update (DHIS2-15167) ([#368](#368)) ([6c54186](6c54186))
|
🎉 This PR is included in version 100.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15167
Requires dhis2/analytics#1478
Key features
TODO
@dhis2/analyticsonce released.Screenshots